Handle non-compliant behaviour of Exasol cursor #28744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @kazanzhy |
potiuk
force-pushed
the
handle-exasol-non-dbapi-2-compliant-behaviour
branch
from
ff1cf3a
to
39b87f7
Compare
2 tasks
eladkal
reviewed
Jan 5, 2023
potiuk
force-pushed
the
handle-exasol-non-dbapi-2-compliant-behaviour
branch
2 times, most recently
from
23f85d4
to
7c63721
Compare
Exasol is not DBAPI-2 compliant, as described in: https://github.com/exasol/pyexasol/blob/master/docs/DBAPI_COMPAT.md This means that SQLOperator cannot be used for it and we should undeprecate the original operator and use specific Exasol handler as default for the returned values. We also add explicit exception in case non-compliant DB2-API database (with missing description) is used with default Operator and handlers. Fixes: apache#28731
potiuk
force-pushed
the
handle-exasol-non-dbapi-2-compliant-behaviour
branch
from
7c63721
to
f2ab384
Compare
|
Fix verified by the user : #28731 (comment) - also fixed all the tests to reflect it. |
eladkal
approved these changes
Jan 9, 2023
|
I think should also increase minimum |
No need. The only difference in common.sql is to raise better exception if someone wants to use directly common.sql operator on Exasol with default handler. All the rest will work regardless from common.sql version. |
37 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exasol is not DBAPI-2 compliant, as described in:
https://github.com/exasol/pyexasol/blob/master/docs/DBAPI_COMPAT.md
This means that SQLOperator cannot be used for it and we should undeprecate the original operator and use specific Exasol handler as default for the returned values.
We also add explicit exception in case non-compliant DB2-API database (with missing description) is used with default Operator and handlers.
Fixes: #28731
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.