Adding possibility for annotations in logs pvc #29270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@potiuk / @jedcunningham could you help in a review here? |
hussein-awala
requested changes
Feb 19, 2023
There was a problem hiding this comment.
Also you need to add a default value annotations: {} to the values file
added 2 commits
February 20, 2023 08:41
…w into pvc-annotations-28745
amoghrajesh
requested review from
hussein-awala
and removed request for
dstandish and
jedcunningham
This was referenced Feb 20, 2023
hussein-awala
requested changes
Feb 20, 2023
hussein-awala
approved these changes
Feb 20, 2023
potiuk
approved these changes
Feb 20, 2023
30 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs persistent volume claim doesn't have the support to add annotations through the helm charts. The PR adds support for the same, similar to https://github.com/apache/airflow/blob/main/chart/templates/dags-persistent-volume-claim.yaml#L32-L35.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.