Remove section check from get-value command #29541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The section check is not really needed and harmful. There should be no problems if sections are missing from the configuration file. Running this check might lead to a problem that if someone stripds down the config file to bare minimum and moves the crucial configuration to env variables the 'get-value' command might fail, even if the configuration is perfectly sound for Airflow. Fixes: apache#29537
potiuk
force-pushed
the
remove-section-check-in-get-value
branch
from
44fe25f
to
d263cf2
Compare
Taragolis
approved these changes
Feb 14, 2023
potiuk
commented
Feb 14, 2023
|
Ah - removed a bit too much :). |
pierrejeambrun
approved these changes
Feb 14, 2023
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 7, 2023
* Remove section check from get-value command The section check is not really needed and harmful. There should be no problems if sections are missing from the configuration file. Running this check might lead to a problem that if someone stripds down the config file to bare minimum and moves the crucial configuration to env variables the 'get-value' command might fail, even if the configuration is perfectly sound for Airflow. Fixes: #29537 * Update airflow/cli/commands/config_command.py (cherry picked from commit 06d45f0)
pierrejeambrun
pushed a commit
that referenced
this pull request
Mar 8, 2023
* Remove section check from get-value command The section check is not really needed and harmful. There should be no problems if sections are missing from the configuration file. Running this check might lead to a problem that if someone stripds down the config file to bare minimum and moves the crucial configuration to env variables the 'get-value' command might fail, even if the configuration is perfectly sound for Airflow. Fixes: #29537 * Update airflow/cli/commands/config_command.py (cherry picked from commit 06d45f0)
64 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The section check is not really needed and harmful. There should be no problems if sections are missing from the configuration file.
Running this check might lead to a problem that if someone stripds down the config file to bare minimum and moves the crucial configuration to env variables the 'get-value' command might fail, even if the configuration is perfectly sound for Airflow.
Fixes: #29537
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.