-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ref anchor for env var link in Connection how-to doc #29816
Conversation
15e5ce1
to
bcc4d5b
Compare
@@ -102,5 +102,5 @@ For example, to add a connection with the connection ID of "dbt_cloud_default": | |||
export AIRFLOW_CONN_DBT_CLOUD_DEFAULT='dbt-cloud://:api_token@my-tenant.getdbt.com' | |||
|
|||
You can refer to the documentation on | |||
:ref:`creating connections via environment variables <environment_variables_secrets_backend>` for more | |||
:ref:`creating connections via environment variables <environment_variables_connections>` for more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same reference anchor was used in the dbt Cloud connection docs too.
bcc4d5b
to
47359b0
Compare
In the "Managing Connections" how-to doc, the "environment variables" links in the doc point to the "Security of connections in the database" section rather than the "Storing connections in environment variables" section.
47359b0
to
1918917
Compare
@eladkal Should we hold off on the merging this for now since the dbt Cloud connection doc is involved here and the next provider wave is in progress? Or it's fine and the dbt Cloud change will just be part of the next wave? |
We can merge but I guess since releases are not synced there will be some time that the reference won't work |
Also, probably we should start look into the cross references of providers -> core. Ideally providers docs should be stand alone. They should not use internal references because we want to treat providers as stand alone packages. |
I think that's fine. It's the only provider that uses this link and there are a few examples of creating the connection with env vars too. |
In the "Managing Connections" how-to doc, the "environment variables" links in the doc point to the "Security of connections in the database" section rather than the "Storing connections in environment variables" section. (cherry picked from commit b33b11b)
In the "Managing Connections" how-to doc, the "environment variables" links in the doc point to the "Security of connections in the database" section rather than the "Storing connections in environment variables" section. (cherry picked from commit b33b11b)
In the "Managing Connections" how-to doc, the "environment variables" links in the doc point to the "Security of connections in the database" section rather than the "Storing connections in environment variables" section.