Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart controller annotations #30126

Merged
merged 8 commits into from
Mar 16, 2023

Conversation

bnguyennhon
Copy link
Contributor

Support custom annotations for the cleanup CronJob and statsd Deployment at the controller level

Similar to how other Deployments in this chart accept annotations and Jobs accept jobAnnotations

closes: #30071
related: #25446

@boring-cyborg boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Mar 15, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 15, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@bnguyennhon bnguyennhon force-pushed the helm-chart-controller-annotations branch from 696e492 to a5392fd Compare March 15, 2023 15:34
@potiuk potiuk force-pushed the helm-chart-controller-annotations branch from a5392fd to c5bc4e6 Compare March 16, 2023 00:11
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make it cleaner before merging it

chart/templates/cleanup/cleanup-cronjob.yaml Outdated Show resolved Hide resolved
chart/templates/statsd/statsd-deployment.yaml Outdated Show resolved Hide resolved
bnguyennhon and others added 2 commits March 16, 2023 09:45
Co-authored-by: Hussein Awala <hussein@awala.fr>
Co-authored-by: Hussein Awala <hussein@awala.fr>
@bnguyennhon
Copy link
Contributor Author

Thanks for the suggestions :)

@potiuk potiuk merged commit 8b634ff into apache:main Mar 16, 2023
@boring-cyborg
Copy link

boring-cyborg bot commented Mar 16, 2023

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:helm-chart Airflow Helm Chart
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm Chart: allow setting annotations for resource controllers (CronJob, Deployment)
3 participants