Add task.trigger rule to grid_data #30130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:UI
bbovenzi
commented
Mar 15, 2023
| @@ -297,7 +297,7 @@ def dag_to_grid(dag: DagModel, dag_runs: Sequence[DagRun], session: Session): | |||
| grouped_tis = {task_id: list(tis) for task_id, tis in itertools.groupby(query, key=lambda ti: ti.task_id)} | |||
|
|
|||
| def task_group_to_grid(item, grouped_tis, *, is_parent_mapped: bool): | |||
| if isinstance(item, AbstractOperator): | |||
| if not isinstance(item, TaskGroup): | |||
There was a problem hiding this comment.
trigger_rule doesn't exist on AbstractOperator. Open to ideas on a better way to check if this is a task or a task group.
Comment on lines
+43
to
+48
| group={{ | ||
| id: "task", | ||
| label: "task", | ||
| instances: [], | ||
| triggerRule: "all_failed", | ||
| }} |
There was a problem hiding this comment.
This feels wrong. A "group" doesn't have a trigger rule. Should this be "node" or "item", not "group"? Definitely a problem for another PR, but we should probably rename this.
There was a problem hiding this comment.
Yeah, I already started a separate branch to make our names and types consistent.
| @@ -297,7 +297,7 @@ def dag_to_grid(dag: DagModel, dag_runs: Sequence[DagRun], session: Session): | |||
| grouped_tis = {task_id: list(tis) for task_id, tis in itertools.groupby(query, key=lambda ti: ti.task_id)} | |||
|
|
|||
| def task_group_to_grid(item, grouped_tis, *, is_parent_mapped: bool): | |||
| if isinstance(item, AbstractOperator): | |||
| if not isinstance(item, TaskGroup): | |||
jedcunningham
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added
task.trigger_ruleto the old graph view in 2.4.0 (see #26043). But that wasn't in the grid view nor in the new graph view.Now it is included in the tooltip and in the instance details panel.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.