Fix issue in pre-importing modules in zipfile #31061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
May 4, 2023
This fixes the scheduler crash due to reading a zipped file as source code when trying to pre-import airflow modules from the python modules in the zip files. The fix was to extract the python modules in the zip file and then pre-import airflow modules in them apply suggestions from code review
ephraimbuddy
force-pushed
the
fix-zip-file-issue
branch
from
eef2232
to
b9cde11
Compare
ashb
approved these changes
May 4, 2023
jedcunningham
approved these changes
May 4, 2023
ephraimbuddy
added a commit
that referenced
this pull request
May 8, 2023
This fixes the scheduler crash due to reading a zipped file as source code when trying to pre-import airflow modules from the python modules in the zip files. The fix was to extract the python modules in the zip file and then pre-import airflow modules in them apply suggestions from code review (cherry picked from commit 34b6230)
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the scheduler crash due to reading a zipped file as source code when trying to pre-import airflow modules from the python modules in the zip files. The fix was to extract the python modules in the zip file and then pre-import airflow modules in them
closes: #31039