Add docstring and signature for _read_remote_logs #31623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not obvious that the "logs" list returned should be have for each element the content of a single log file (it's easy to make the mistake of thinking it should be a list of individual log lines but this is not correct).
boring-cyborg
bot
added
area:logging
area:providers
provider:amazon-aws
jedcunningham
approved these changes
May 31, 2023
uranusjr
reviewed
May 31, 2023
uranusjr
approved these changes
May 31, 2023
eladkal
pushed a commit
that referenced
this pull request
Jun 8, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit ce7766e)
eladkal
pushed a commit
that referenced
this pull request
Jun 9, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit ce7766e)
86 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not obvious that the "logs" list returned should be have for each element the content of a single log file (it's easy to make the mistake of thinking it should be a list of individual log lines but this is not correct).