Allow auth managers to override the security manager #32525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincbeck
requested review from
jhtimmins,
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
uranusjr
reviewed
Jul 12, 2023
uranusjr
reviewed
Jul 12, 2023
uranusjr
reviewed
Jul 13, 2023
o-nikolas
reviewed
Jul 13, 2023
uranusjr
reviewed
Jul 14, 2023
o-nikolas
approved these changes
Jul 14, 2023
|
@uranusjr Could you please review? |
Or maybe @potiuk or @jedcunningham? |
uranusjr
reviewed
Jul 20, 2023
uranusjr
reviewed
Jul 20, 2023
ferruzzi
approved these changes
Jul 24, 2023
This was referenced Jul 24, 2023
ephraimbuddy
added
the
changelog:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current security manager is highly dependent on FAB (Flask App Builder). One of the goal of AIP-56 is to move these FAB related operations to the auth manager. This PR adds capability for the auth manager to override the security manager. As such, overtime and multiple iteration/PRs we can move slowly operations/methods which are in the security manager to the security manager override defined in the auth manager module.
This PR moves
register_viewsand few other small methods from core Airflow to the auth manager module. Again, the goal is to move by iterations things from the security manager (in core Airflow) to the auth manager module.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.