Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Executors discovery and documentation #32532

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Jul 11, 2023

The Executors can now be added via providers. This PR adds
mechanism of discovering the executors via Providers Manager,
exposing them via CLI and documenting in core-extensions.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg boring-cyborg bot added area:CLI area:dev-tools area:helm-chart Airflow Helm Chart provider:cncf-kubernetes Kubernetes provider related issues area:providers area:Scheduler including HA (high availability) scheduler kind:documentation provider:celery labels Jul 11, 2023
@potiuk potiuk changed the title Add executors discovery to providers Add Executors discovery and documentation Jul 11, 2023
@potiuk
Copy link
Member Author

potiuk commented Jul 11, 2023

Based on #32526, so only last commit counts.

@potiuk potiuk force-pushed the add-executors-discovery-to-providers branch from e961bd0 to a12f4c3 Compare July 12, 2023 06:59
The Executors can now be added via providers. This PR adds
mechanism of discovering the executors via Providers Manager,
exposing them via CLI and documenting in core-extensions.
@potiuk potiuk force-pushed the add-executors-discovery-to-providers branch from 3a8fec1 to d779a03 Compare July 12, 2023 07:23
@potiuk potiuk merged commit 624211f into apache:main Jul 12, 2023
1 check passed
@potiuk potiuk deleted the add-executors-discovery-to-providers branch July 12, 2023 20:14
"type": "array",
"description": "Notification class names",
"items": {
"type": "string"
}
},
},
"executors": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice, I know I'm late to this PR but this is great! I was planning on adding a section to the schema exactly like this when we're ready to land our first AWS executor. Thanks for beating us to it @potiuk 😄

pateash pushed a commit to pateash/airflow that referenced this pull request Jul 23, 2023
* Add Executors discovery and documentation

The Executors can now be added via providers. This PR adds
mechanism of discovering the executors via Providers Manager,
exposing them via CLI and documenting in core-extensions.

* Update scripts/in_container/verify_providers.py
@ephraimbuddy ephraimbuddy added the type:new-feature Changelog: New Features label Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:CLI area:dev-tools area:helm-chart Airflow Helm Chart area:providers area:Scheduler including HA (high availability) scheduler kind:documentation provider:celery provider:cncf-kubernetes Kubernetes provider related issues type:new-feature Changelog: New Features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants