-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Executors discovery and documentation #32532
Merged
potiuk
merged 2 commits into
apache:main
from
potiuk:add-executors-discovery-to-providers
Jul 12, 2023
Merged
Add Executors discovery and documentation #32532
potiuk
merged 2 commits into
apache:main
from
potiuk:add-executors-discovery-to-providers
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested review from
ashb,
dstandish,
jedcunningham,
kaxil,
XD-DENG,
o-nikolas and
pierrejeambrun
as code owners
July 11, 2023 22:58
boring-cyborg
bot
added
area:CLI
area:dev-tools
area:helm-chart
Airflow Helm Chart
provider:cncf-kubernetes
Kubernetes provider related issues
area:providers
area:Scheduler
including HA (high availability) scheduler
kind:documentation
provider:celery
labels
Jul 11, 2023
potiuk
changed the title
Add executors discovery to providers
Add Executors discovery and documentation
Jul 11, 2023
Based on #32526, so only last commit counts. |
ferruzzi
reviewed
Jul 11, 2023
ferruzzi
reviewed
Jul 11, 2023
ferruzzi
reviewed
Jul 11, 2023
ferruzzi
reviewed
Jul 11, 2023
ferruzzi
reviewed
Jul 11, 2023
ferruzzi
reviewed
Jul 11, 2023
potiuk
force-pushed
the
add-executors-discovery-to-providers
branch
from
July 12, 2023 06:59
e961bd0
to
a12f4c3
Compare
The Executors can now be added via providers. This PR adds mechanism of discovering the executors via Providers Manager, exposing them via CLI and documenting in core-extensions.
potiuk
force-pushed
the
add-executors-discovery-to-providers
branch
from
July 12, 2023 07:23
3a8fec1
to
d779a03
Compare
ferruzzi
reviewed
Jul 12, 2023
potiuk
commented
Jul 12, 2023
ferruzzi
approved these changes
Jul 12, 2023
o-nikolas
reviewed
Jul 12, 2023
"type": "array", | ||
"description": "Notification class names", | ||
"items": { | ||
"type": "string" | ||
} | ||
}, | ||
}, | ||
"executors": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niiice, I know I'm late to this PR but this is great! I was planning on adding a section to the schema exactly like this when we're ready to land our first AWS executor. Thanks for beating us to it @potiuk 😄
pateash
pushed a commit
to pateash/airflow
that referenced
this pull request
Jul 23, 2023
* Add Executors discovery and documentation The Executors can now be added via providers. This PR adds mechanism of discovering the executors via Providers Manager, exposing them via CLI and documenting in core-extensions. * Update scripts/in_container/verify_providers.py
69 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area:CLI
area:dev-tools
area:helm-chart
Airflow Helm Chart
area:providers
area:Scheduler
including HA (high availability) scheduler
kind:documentation
provider:celery
provider:cncf-kubernetes
Kubernetes provider related issues
type:new-feature
Changelog: New Features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Executors can now be added via providers. This PR adds
mechanism of discovering the executors via Providers Manager,
exposing them via CLI and documenting in core-extensions.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.