Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Amazon SageMaker Notebook hook and operators #33219

Merged
merged 28 commits into from
Aug 16, 2023
Merged

Conversation

ellisms
Copy link
Contributor

@ellisms ellisms commented Aug 8, 2023

Closes: #32702
Created new hook and Operators for Amazon SageMaker Notebooks Instances. Allows user to create, start, stop, and delete notebook instances.
Created unit tests for hook and operators and system test. All tests passed.
Updated documentation for new operator.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 8, 2023

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments. Most of them are related to style/convention. Overall it is pretty good! Thanks for doing these changes.

airflow/providers/amazon/aws/hooks/sagemaker_notebook.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/hooks/sagemaker_notebook.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/hooks/sagemaker_notebook.py Outdated Show resolved Hide resolved
scripts/ci/docker-compose/empty/git_version Outdated Show resolved Hide resolved
@ellisms
Copy link
Contributor Author

ellisms commented Aug 14, 2023

Updated the PR with the suggested changes, except the file location for the operator. Open to feedback on whether to integrate into the existing sageMaker file, or leave as-is.

@vincbeck
Copy link
Contributor

Updated the PR with the suggested changes, except the file location for the operator. Open to feedback on whether to integrate into the existing sageMaker file, or leave as-is.

Integrating it into the existing SageMaker file makes sense to me ;)

airflow/providers/amazon/aws/hooks/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
scripts/ci/docker-compose/empty/git_version Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
airflow/providers/amazon/aws/operators/sagemaker.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A last nit :) Thanks for your reactivity!

ellisms and others added 9 commits August 16, 2023 10:35
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
ellisms and others added 18 commits August 16, 2023 10:35
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Copy link
Contributor

@vincbeck vincbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for your work and reactivity! This is really good! I'll merge it once the tests are passing

Copy link
Contributor

@eladkal eladkal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
will merge when CI is green

@vincbeck vincbeck merged commit 223b41d into apache:main Aug 16, 2023
42 checks passed
@boring-cyborg
Copy link

boring-cyborg bot commented Aug 16, 2023

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

ferruzzi pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Aug 17, 2023

---------

Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for SageMaker Notebook Operators
3 participants