-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set strict to True when parsing dates in webserver views #33512
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
August 18, 2023 21:59
potiuk
force-pushed
the
fix/parsing_dates
branch
from
August 19, 2023 20:56
88d0ba5
to
3792599
Compare
I rebased it - but I think there will still be test failures. |
hussein-awala
force-pushed
the
fix/parsing_dates
branch
from
August 19, 2023 22:30
3792599
to
cc1e4b6
Compare
uranusjr
reviewed
Aug 20, 2023
uranusjr
reviewed
Aug 20, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
potiuk
approved these changes
Aug 20, 2023
pankajkoti
approved these changes
Aug 20, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Aug 28, 2023
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> --------- Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com> (cherry picked from commit 4390524)
97 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #33478
(I prefer to keep it open after merging this one)
This PR switch to strict datetime parsing to avoid rendering the views with unexpected dates:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.