Add DagModel attributes before dumping DagDetailSchema for get_dag_details API endpoint #34947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RNHTTR
changed the title
uranusjr
reviewed
Oct 18, 2023
RNHTTR
force-pushed
the
add-missing-data-to-get-dag-details-endpoint
branch
from
eda5e8e
to
6f2c73c
Compare
RNHTTR
requested review from
ryanahamilton,
ashb,
bbovenzi,
kaxil and
XD-DENG
as code owners
RNHTTR
force-pushed
the
add-missing-data-to-get-dag-details-endpoint
branch
from
6f2c73c
to
ec52276
Compare
uranusjr
reviewed
Nov 10, 2023
There was a problem hiding this comment.
Are quote changes in this file needed? They are obscuring the actual addition…
There was a problem hiding this comment.
I'm not sure what you mean by quote changes
There was a problem hiding this comment.
There are an important number of lines changed located in the OpenAPI spec. All simple quotes are moved to double quotes.
I also agree that it makes the addition harder to review, I suggest we do this in a separate PR (I don't think it is needed in this particular PR).
Makes me realize that we do not have yamllint activated on our OpenAPI Spec to enforce common style.
uranusjr
reviewed
Nov 10, 2023
|
A couple of minor questions, otherwise lgtm. |
uranusjr
approved these changes
Nov 22, 2023
eladkal
approved these changes
Nov 24, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
…tails API endpoint (#34947) * Add DagModel attributes before dumping DagDetailSchema * fix tests * fix tests * missed an f-string :( * apply dag attributes to dag model instead of other way around * pass session to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #33482
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.