fix: set dry_run to be optional. #35167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austinau
requested review from
ephraimbuddy and
pierrejeambrun
as code owners
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
|
hussein-awala
approved these changes
Oct 24, 2023
Taragolis
reviewed
Oct 24, 2023
| "task_id": "print_the_context", | ||
| } | ||
| assert expected_result == result | ||
|
|
There was a problem hiding this comment.
Extra spaces here, it should be removed for pass Static Checks
There was a problem hiding this comment.
May want to setup pre-commit hooks - https://github.com/apache/airflow/blob/main/CONTRIBUTORS_QUICK_START.rst#id12
eladkal
reviewed
Oct 27, 2023
added 2 commits
October 30, 2023 16:15
|
Alright, I removed the whitespace, thanks! |
|
Any update on this PR? |
eladkal
approved these changes
Nov 25, 2023
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 26, 2023
* fix: set dry_run to be optional. * Update tests/api_connexion/schemas/test_task_instance_schema.py * Removed extra whitespace. --------- Co-authored-by: austin <austin.unsicker@advancedmd.com> Co-authored-by: Elad Kalif <45845474+eladkal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #35166. Duplicates the solution in #34568.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.