Better error message when sqlite URL uses relative path #36774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @mac2000 |
When sqlite URL uses relative path, the error printed is quite cryptic: ``` sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) unable to open database file ``` This might easily happen for example when you are in a hurry and put relative value in your AIRFLOW_HOME. This PR checks if sql is relative and throws more appropriate and explicit message what is wrong.
potiuk
force-pushed
the
add-sqlite-check-for-relative-path
branch
from
ccc813f
to
385f23a
Compare
jscheffl
approved these changes
Jan 14, 2024
Taragolis
approved these changes
Jan 14, 2024
|
Same here - cherry-picked to 2.8.1 @ephraimbuddy |
ephraimbuddy
added
type:bug-fix
ephraimbuddy
pushed a commit
that referenced
this pull request
Jan 15, 2024
When sqlite URL uses relative path, the error printed is quite cryptic: ``` sqlalchemy.exc.OperationalError: (sqlite3.OperationalError) unable to open database file ``` This might easily happen for example when you are in a hurry and put relative value in your AIRFLOW_HOME. This PR checks if sql is relative and throws more appropriate and explicit message what is wrong. (cherry picked from commit 082055e)
68 tasks
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sqlite URL uses relative path, the error printed is quite cryptic:
This might easily happen for example when you are in a hurry and put relative value in your AIRFLOW_HOME.
This PR checks if sql is relative and throws more appropriate and explicit message what is wrong.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.