Add deferrable functionality to the AirbyteJobSensor and AirbyteTriggerSyncOperator #36780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishronek
changed the title
chrishronek
commented
Jan 15, 2024
Taragolis
reviewed
Jan 15, 2024
pankajastro
reviewed
Jan 15, 2024
chrishronek
changed the title
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new deferrable sensor for the Airbyte provider. It's a drop-in replacement for the
AirbyteJobSensor. I've also included theAirbyteSyncTriggeralongside the new sensor with the logic to defer the task. I wrote tests for the trigger component and docs for the deferrable operator.I am happy to continue iterating on this as needed - if I missed anything, let me know. It's my first PR that I'm merging into the Airflow project.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.