-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttributeError: 'DagRunNote' object has no attribute 'dag_id' #38843
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Request change to block merging this.
I just noticed that we don't have dag_id column in this table, the dag_run_id is not unique, so this could be a bug, I'll test it first, then decide whether to merge this or fix the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The run id here is the auto-generated integer id of dag_run
table.
prefix = f"<{self.__class__.__name__}: {self.dag_id}.{self.dagrun_id} {self.run_id}" | ||
if self.map_index != -1: | ||
prefix += f" map_index={self.map_index}" | ||
prefix = f"<{self.__class__.__name__}: {self.dag_run.dag_id}.{self.dag_run_id} {self.dag_run.run_id} {self.content}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should still show map_index. Honestly I’m not event sure why dag_run_id
should be shown, it is just a number and not really useful in any way.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
'DagRunNote' object has no attribute dag_id\dagrun_id\run_id\map_index
so replace those attributes to existing attributes dag_run_id\content
Closes: #38816