Add logic to handle on_kill for BigQueryInsertJobOperator when deferrable=True #38912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
sunank200
force-pushed
the
fix-bigquery-insert-job-on-kill
branch
3 times, most recently
from
3fe5af1
to
a5cd68d
Compare
sunank200
force-pushed
the
fix-bigquery-insert-job-on-kill
branch
from
a5cd68d
to
4078368
Compare
Lee-W
reviewed
Apr 12, 2024
tirkarthi
reviewed
Apr 13, 2024
sunank200
force-pushed
the
fix-bigquery-insert-job-on-kill
branch
from
289520c
to
1b234c4
Compare
sunank200
force-pushed
the
fix-bigquery-insert-job-on-kill
branch
from
6503101
to
a3dbbf2
Compare
|
This PR looks good to me. I'm planning on merging it later today. But please let me know if anyone wants to take a deeper look 🙂 |
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
sunank200
force-pushed
the
fix-bigquery-insert-job-on-kill
branch
from
a3dbbf2
to
a2311c7
Compare
|
@sunank200 As I understand this will kill the job when triggerer is restarted for deployment, maintenance etc or marked unhealthy in HA mode with the trigger to be handled by another triggerer job as the task is cancelled by asyncio and the |
|
@Lee-W @sunank200 @tirkarthi this PR is NOT safe, and needs to be reverted or updated. Please see my #36090 (comment) for more information. |
66 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request aims to improve the cancellation logic of the
BigQueryInsertJobOperatorwhen set todeferrable=True. Previously,cancel_on_kill=Trueworked well in non-deferrable mode but did not function as expected indeferrable=Truemode. This bug has been resolved with this change. However, the bug has a larger scope and is a generic issue in the trigger. An issue has already been raised on Airflow regarding this matter and can be found at #36090.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.