[OpenLineage] Add more debug logs to facilitate debugging #39136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kacpermuda
force-pushed
the
ol-improve-logging
branch
from
a37da53
to
9c6cf16
Compare
kacpermuda
force-pushed
the
ol-improve-logging
branch
2 times, most recently
from
7b12975
to
a7a063b
Compare
kacpermuda
force-pushed
the
ol-improve-logging
branch
from
a7a063b
to
b88c122
Compare
uranusjr
reviewed
Apr 30, 2024
kacpermuda
force-pushed
the
ol-improve-logging
branch
3 times, most recently
from
4327c2f
to
ada8e2a
Compare
kacpermuda
force-pushed
the
ol-improve-logging
branch
2 times, most recently
from
ec0786d
to
1f440aa
Compare
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
kacpermuda
force-pushed
the
ol-improve-logging
branch
from
1f440aa
to
a26bffa
Compare
mobuchowski
approved these changes
May 13, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After debugging some user issues i feel like we could add some more DEBUG level logs, so that we can deduce more information about what's happening inside OpenLineage. We should be able to trace the whole flow from loading the plugin, through configuration to event being emitted. We should not have to ask users for their configuration for simple debugging.
I will follow up with another PR for OpenLineage Python client, so that it's also as descriptive as possible.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.