Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DatabricksNotebookOperator #39178

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

pankajkoti
Copy link
Member

@pankajkoti pankajkoti commented Apr 22, 2024

This pull request introduces the DatabricksNotebookOperator
to the Airflow Databricks provider from the astro-provider-databricks
repository.
It marks one of the initial pull requests aimed at contributing
operators and features from that repository into the Airflow
Databricks provider.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

Copy link
Contributor

@tatiana tatiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking very good, @pankajkoti , thanks for contributing this!

@pankajkoti pankajkoti changed the title Contribute databricks notebook operator Contribute DatabricksNotebookOperator from astro-provider-databricks repo Apr 23, 2024
@pankajkoti pankajkoti requested a review from tatiana April 23, 2024 11:42
@pankajkoti pankajkoti force-pushed the contribute-databricks-notebook-operator branch from fb7b1a3 to bd08d9d Compare April 23, 2024 11:43
@Lee-W Lee-W requested review from Lee-W and removed request for tatiana April 23, 2024 13:23
@pankajkoti pankajkoti requested a review from tatiana April 23, 2024 13:57
@pankajkoti pankajkoti marked this pull request as ready for review April 24, 2024 06:44
@eladkal eladkal changed the title Contribute DatabricksNotebookOperator from astro-provider-databricks repo Add DatabricksNotebookOperator Apr 24, 2024
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
airflow/providers/databricks/operators/databricks.py Outdated Show resolved Hide resolved
tests/providers/databricks/operators/test_databricks.py Outdated Show resolved Hide resolved
tests/providers/databricks/operators/test_databricks.py Outdated Show resolved Hide resolved
tests/providers/databricks/operators/test_databricks.py Outdated Show resolved Hide resolved
@pankajkoti pankajkoti force-pushed the contribute-databricks-notebook-operator branch from be84ec0 to 20dacc7 Compare April 25, 2024 13:05
@pankajkoti pankajkoti requested a review from Lee-W April 25, 2024 13:06
@Lee-W Lee-W merged commit 7683344 into apache:main Apr 26, 2024
41 checks passed
@Lee-W Lee-W deleted the contribute-databricks-notebook-operator branch April 26, 2024 08:41
pankajkoti pushed a commit that referenced this pull request May 14, 2024
related: #39178

This PR intends to make DatabricksNotebookOperator deferrable
pankajkoti added a commit that referenced this pull request May 30, 2024
This pull request introduces the [DatabricksWorkflowTaskGroup](https://github.com/astronomer/astro-provider-databricks/blob/main/src/astro_databricks/operators/workflow.py#L226)
to the Airflow Databricks provider from the [astro-provider-databricks](https://github.com/astronomer/astro-provider-databricks/tree/main)
repository. 
It marks another pull request aimed at contributing 
operators and features from that repository into the Airflow 
Databricks provider, the previous PR being #39178.

The task group launches a [Databricks Workflow](https://docs.databricks.com/en/workflows/index.html) 
and runs the notebook jobs from within it, resulting in a 
[75% cost reduction](https://www.databricks.com/product/pricing) ($0.40/DBU for all-purpose compute, 
$0.07/DBU for Jobs compute) when compared to executing 
``DatabricksNotebookOperator`` outside of ``DatabricksWorkflowTaskGroup``.

---------
Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
This pull request introduces the [DatabricksWorkflowTaskGroup](https://github.com/astronomer/astro-provider-databricks/blob/main/src/astro_databricks/operators/workflow.py#L226)
to the Airflow Databricks provider from the [astro-provider-databricks](https://github.com/astronomer/astro-provider-databricks/tree/main)
repository. 
It marks another pull request aimed at contributing 
operators and features from that repository into the Airflow 
Databricks provider, the previous PR being apache#39178.

The task group launches a [Databricks Workflow](https://docs.databricks.com/en/workflows/index.html) 
and runs the notebook jobs from within it, resulting in a 
[75% cost reduction](https://www.databricks.com/product/pricing) ($0.40/DBU for all-purpose compute, 
$0.07/DBU for Jobs compute) when compared to executing 
``DatabricksNotebookOperator`` outside of ``DatabricksWorkflowTaskGroup``.

---------
Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
related: apache#39178

This PR intends to make DatabricksNotebookOperator deferrable
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
This pull request introduces the [DatabricksWorkflowTaskGroup](https://github.com/astronomer/astro-provider-databricks/blob/main/src/astro_databricks/operators/workflow.py#L226)
to the Airflow Databricks provider from the [astro-provider-databricks](https://github.com/astronomer/astro-provider-databricks/tree/main)
repository. 
It marks another pull request aimed at contributing 
operators and features from that repository into the Airflow 
Databricks provider, the previous PR being apache#39178.

The task group launches a [Databricks Workflow](https://docs.databricks.com/en/workflows/index.html) 
and runs the notebook jobs from within it, resulting in a 
[75% cost reduction](https://www.databricks.com/product/pricing) ($0.40/DBU for all-purpose compute, 
$0.07/DBU for Jobs compute) when compared to executing 
``DatabricksNotebookOperator`` outside of ``DatabricksWorkflowTaskGroup``.

---------
Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
pankajkoti added a commit to astronomer/astro-provider-databricks that referenced this pull request Aug 8, 2024
As part of Astronomer's internal plans and decisions, we've decided to contribute the existing functionality provided by the operators and plugins in this repository to the official Apache Airflow Databricks provider. To achieve this, we submitted the following PRs to the Airflow provider:

1. apache/airflow#39178
2. apache/airflow#39771
3. apache/airflow#40013
4. apache/airflow#40724
5. apache/airflow#39295

All functionality has now been contributed to the Airflow Databricks provider, and ongoing support will be maintained there. As a result, we're deprecating the operators and plugins in this repository. Users are encouraged to transition to the official Apache Airflow Databricks provider as soon as possible. The migration process is straightforward—simply update the import path to point to the Airflow provider and ensure that you install `apache-airflow-providers-databricks>=6.8.0`, which includes all the contributions mentioned above.

closes: astronomer/issues-airflow#715
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 9, 2024
This pull request introduces the [DatabricksWorkflowTaskGroup](https://github.com/astronomer/astro-provider-databricks/blob/main/src/astro_databricks/operators/workflow.py#L226)
to the Airflow Databricks provider from the [astro-provider-databricks](https://github.com/astronomer/astro-provider-databricks/tree/main)
repository.
It marks another pull request aimed at contributing
operators and features from that repository into the Airflow
Databricks provider, the previous PR being apache/airflow#39178.

The task group launches a [Databricks Workflow](https://docs.databricks.com/en/workflows/index.html)
and runs the notebook jobs from within it, resulting in a
[75% cost reduction](https://www.databricks.com/product/pricing) ($0.40/DBU for all-purpose compute,
$0.07/DBU for Jobs compute) when compared to executing
``DatabricksNotebookOperator`` outside of ``DatabricksWorkflowTaskGroup``.

---------
Co-authored-by: Daniel Imberman <daniel.imberman@gmail.com>
Co-authored-by: Tatiana Al-Chueyr <tatiana.alchueyr@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
GitOrigin-RevId: 2ecf7fa07d6d681c73ae4831801f9d98db298d89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants