-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] get all failed tasks errors in exception #39354
[FEAT] get all failed tasks errors in exception #39354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about the test case when multiple parallel tasks failed? is that a valid scenario?
yes, The current logic is iterating through all failed tasks, hitting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. And yes, would be nice to have that additional test case as mentioned earlier from @dirrao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. but yep, would be great if we could have tests cover this change 🙂
1ac4763
to
b6eaf9d
Compare
b6eaf9d
to
2c8b929
Compare
As it's approved by many, I think we're good to merge this one |
get_run_output
api calling and raising the exception with all failed tasks errors^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.