Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deferrable mode for BeamRunJavaPipelineOperator #39371

Merged
merged 1 commit into from
May 14, 2024

Conversation

MaksYermak
Copy link
Contributor

In this PR I have prepared a fix for an error in deferrable mode for BeamRunJavaPipelineOperator.

This error happens on a distributed system when the user has trigger and worker on different machines. BeamRunJavaPipelineOperator needs a local jar file for starting a Job. Users can specify a path to jar file which is located in GCS bucket and then the operator will download this file to the local system. In the current deferrable mode implementation operator downloads jar file before going to the deferrable mode. It means that on a distributed system the file is downloaded on the worker machine not on the trigger machine. And then when the operator tries to execute a Job on the trigger machine Airflow throws an error that the executable jar file does not exist.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@VladaZakharova
Copy link
Contributor

Hi @eladkal @potiuk !
Can you please check the changes here? Thanks!

@eladkal eladkal requested a review from Lee-W May 11, 2024 06:52
@MaksYermak MaksYermak force-pushed the fix-defer-mode-beam-java-operator branch from 14e4629 to 6361ef4 Compare May 14, 2024 11:21
@MaksYermak
Copy link
Contributor Author

@potiuk @Lee-W I have updated the code.

@Lee-W Lee-W merged commit 1489cf7 into apache:main May 14, 2024
40 checks passed
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants