Unify lazy db sequence implementations #39426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uranusjr
force-pushed
the
refactor-sequence-db-interface
branch
2 times, most recently
from
2574c3c
to
6c72107
Compare
uranusjr
commented
May 6, 2024
Lee-W
reviewed
May 7, 2024
uranusjr
force-pushed
the
refactor-sequence-db-interface
branch
3 times, most recently
from
781ef71
to
b0e6eaf
Compare
Lee-W
reviewed
May 8, 2024
Lee-W
approved these changes
May 8, 2024
ephraimbuddy
reviewed
May 8, 2024
docs/apache-airflow/authoring-and-scheduling/dynamic-task-mapping.rst
Outdated
Show resolved
Hide resolved
ephraimbuddy
approved these changes
May 8, 2024
eladkal
approved these changes
May 8, 2024
phanikumv
approved these changes
May 8, 2024
uranusjr
force-pushed
the
refactor-sequence-db-interface
branch
from
68c00fa
to
502bdad
Compare
LazyXComAccessor and InletEventsAccessor are somewhat similar in purpose. A new LazySelectSequence is introduced with a more generic implementation that fits both use cases. This also implements the Sequence protocol a bit more efficiently in some places.
uranusjr
force-pushed
the
refactor-sequence-db-interface
branch
from
502bdad
to
3ee6f7c
Compare
sunank200
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LazyXComAccessor and InletEventsAccessor are somewhat similar in purpose. A new LazySelectSequence is introduced with a more generic implementation that fits both use cases. This also implements the Sequence protocol a bit more efficiently in some places.
See #39367 for some context.