-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OPENLINEAGE] Introduce AirflowJobFacet and AirflowStateRunFacet #39520
Conversation
35778b2
to
ea6a570
Compare
ea6a570
to
d02af81
Compare
3d6af0d
to
7c0e499
Compare
77020dd
to
ec4bc16
Compare
I had to add some words to spelling wordlist, due to the docs error in CI here. Let me know if there is a better solution to that problem, but part of these words have already been present, just with different capitalization. |
ec4bc16
to
c57294d
Compare
I also added json specs for the facets, in a new directory. I was not sure if i should add the |
c57294d
to
8a86b29
Compare
c415d62
to
773637a
Compare
773637a
to
43abcf8
Compare
Yes. When you run tests in PR "selective" checks are run, but when you run them in main "all" tests are run. In this case, there is an inconsistenty between what is excluded and what is included. On one hand selective checks want to run Look at the command executed:
From selective checks:
From compatibility check we have Apparently pytest overrides the ignore when we explicitly have |
This is the command that will be used after #40037 is merged and you rebase your PR (tests/providers/common/io is gone as explicit pytest parameter):
|
Rebased after merging #40037 to see if it helps. |
OK. The original problem is fixed. Now the remaining problem is to add compatibility so that the openlineage tests can be run on Airflow 2.7 as well (following the different cases of how to handle compatibility described in the unit_tests.rst). |
0546e39
to
63d051a
Compare
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
63d051a
to
38c9523
Compare
I fixed all the compatibility tests and adjusted the code itself so it works on all Airflow 2.7+ versions now without any issues. Imho it's ready to be merged |
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
closes: #39467
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.