Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add custom provider runtime checks #39609

Merged
merged 1 commit into from
May 17, 2024

Conversation

kacpermuda
Copy link
Contributor

As discussed here at pr #39513, changes introduced by #39336 make all previous OpenLineage provider versions incompatible with Airflow >= 2.10.0 (due to changes in try_number behaviour change in core Airflow).

Using previous version of provider is still possible for Airflow >= 2.10.0, but will cause invalid behaviour (yet it will not cause any errors). We can't modify already released versions and provide a max supported Airflow version so we'd like to have a runtime check to ensure that a compatible version of OL provider is installed


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

airflow/settings.py Outdated Show resolved Hide resolved
@potiuk
Copy link
Member

potiuk commented May 14, 2024

Also - we need to actually bump openlineage to 1.8.0 in provider.yaml to make the Provider tests pass (it failed now correctly detecting wrong version :D).

@kacpermuda
Copy link
Contributor Author

I was wondering how to do it aside the release process not to break anything, as doing it by hand seemed really wrong to me . I modified the changelog, init and provider.yaml, is that the correct approach ? I want to make sure that for the next release it will not get bumped again, and in result the 1.8.0 will not exist.

@potiuk
Copy link
Member

potiuk commented May 14, 2024

Yes. It's OK. But @eladkal needs to know it has been done.

@potiuk
Copy link
Member

potiuk commented May 14, 2024

BTW. Both workflows aare fine. It's generally OK to bump minor version of package if we know change is breakin. The breeze release-management prepare-provider-documentation will see it and rather than bumping it, it will just tell release manager "hey this package is going to be relased in new major version` .

@kacpermuda
Copy link
Contributor Author

Also, where are we with Airflow 2.10 on timeline? Do you think there will be time for next providers release before the 2.10. release? We need to make sure that, by accident, we don't get the apache-airflow-providers-openlineage < 1.8.0 in Airflow 2.10 constraints 😄

@potiuk
Copy link
Member

potiuk commented May 14, 2024

Also, where are we with Airflow 2.10 on timeline? Do you think there will be time for next providers release before the 2.10. release? We need to make sure that, by accident, we don't get the apache-airflow-providers-openlineage < 1.8.0 in Airflow 2.10 constraints 😄

No worries, that will take quite some time (months rather than weeks).

@kacpermuda
Copy link
Contributor Author

@potiuk @eladkal It's all green, so if there are no more things to do here i think it can be merged.

@potiuk
Copy link
Member

potiuk commented May 14, 2024

@eladkal ?

@kacpermuda kacpermuda force-pushed the runtime-providers-checks branch 2 times, most recently from c712b77 to 20e22fb Compare May 16, 2024 10:58
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
@potiuk potiuk merged commit 4de79a0 into apache:main May 17, 2024
42 checks passed
@kacpermuda kacpermuda deleted the runtime-providers-checks branch May 17, 2024 10:37
@utkarsharma2
Copy link
Contributor

utkarsharma2 commented May 22, 2024

I think we should also update apache-airflow-providers-openlineage==1.8.0 the constraint in constraint-main for all Python versions.

@eladkal
Copy link
Contributor

eladkal commented May 22, 2024

I think we should also update apache-airflow-providers-openlineage==1.8.0 the constraint in constraint-main for all Python versions.

constraints-main is updated automatically. sometimes it takes time for the job to be completed

@potiuk
Copy link
Member

potiuk commented May 22, 2024

constraints-main is updated automatically. sometimes it takes time for the job to be completed

Seems that they have not been updated for a while, there were few main failures to prevent it but likely after #39747 we are likely to get them updated

@utkarsharma2
Copy link
Contributor

@potiuk @eladkal Thanks :)

@utkarsharma2 utkarsharma2 added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jun 3, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Signed-off-by: Kacper Muda <mudakacper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants