Fix BigQueryCursor execute method if the location is missing #39659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
e-galan
force-pushed
the
fix-bigquery-value-check-operator_job_location_bug
branch
from
d6bd308
to
a8b8013
Compare
dirrao
requested changes
May 16, 2024
@dirrao I can add a unit test, but it will be totally dependent on mocks, because the problem happens between the two client requests. Will that do? I can't fix the static check, it fails because of smth that does not seem related to my PR: |
|
This static check failure not relevant your PR, it will be fix (at least temporary) by #39662 |
eladkal
force-pushed
the
fix-bigquery-value-check-operator_job_location_bug
branch
from
a8b8013
to
2cd6917
Compare
We have system tests for google so probably we should modify/add coverage there. @VladaZakharova WDYT? |
e-galan
force-pushed
the
fix-bigquery-value-check-operator_job_location_bug
branch
from
2cd6917
to
9f33610
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where
BigQueryValueCheckOperatortasks failed if it was not provided with the location parameter and the dataset location was outside of the US.If the location parameter is not provided to
BigQueryValueCheckOperator, then the location parameter will still be None when execution reaches theBigQueryCursorexecute method. The execute method makes two client requests: the first to the BigQuery client, which can work without the location provided, the second to the Google Discovery client, which cannot find a resource without the location resulting in a error.Pulling the location from a successful BigQuery request result resolves that problem.
Change list:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.