-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolving EMR deprecated warnings #39743
Conversation
Static checks are failing |
I'm not sure what this is meant to be fixing, but we definitely don't want to be adding waiter_delay and waiter_max_attempts to every operator in every system test... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also agree from the description and code I have no idea what issue is attempting to be fixed here. Can you provide more details to make your PR easier for others to review?
@o-nikolas and @ferruzzi As per the recommendation from @Taragolis, Fix the operator code or adjust the operator default values at the time of removing deprecated code.
|
4ed771e
to
59866b0
Compare
96ede5a
to
49b8855
Compare
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
Co-authored-by: Vincent <97131062+vincbeck@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, fixing the operator(s) makes much more sense than changing the tests.
Resolving EMR deprecated warnings
related: #39485