Add typing for SqlSensor #39773
Merged
Add typing for SqlSensor #39773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josh-fell
force-pushed
the
sqlsensor-typing
branch
3 times, most recently
from
acc3986
to
0f58d17
Compare
The SqlSensor was missing typing mainly in its constructor where it would be most valuable from a DAG author's perspective. This PR adds said typing of the sensor, its stubs, and tests (where applicable) as well as a small cleanup of the sensor's docstring.
josh-fell
force-pushed
the
sqlsensor-typing
branch
from
0f58d17
to
e28905c
Compare
vincbeck
approved these changes
May 23, 2024
jedcunningham
approved these changes
May 24, 2024
RNHTTR
pushed a commit
to RNHTTR/airflow
that referenced
this pull request
Jun 1, 2024
The SqlSensor was missing typing mainly in its constructor where it would be most valuable from a DAG author's perspective. This PR adds said typing of the sensor, its stubs, and tests (where applicable) as well as a small cleanup of the sensor's docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SqlSensor was missing typing mainly in its constructor where it would be most valuable from a DAG author's perspective. This PR adds said typing of the sensor, its stubs, and tests (where applicable) as well as a small cleanup of the sensor's docstring.