Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BashOperator and Bash decorator for consistency and simplicity #39871

Merged
merged 2 commits into from
May 28, 2024

Conversation

Nick-dv
Copy link
Contributor

@Nick-dv Nick-dv commented May 27, 2024

Documentation https://airflow.apache.org/docs/apache-airflow/stable/howto/operator/bash.html has two problems

  1. Bashoperator bash-command has unnecessary complexity which steals focus from the airflow operator itself.
  2. @task.bash and BashOperator commands are different. For better comparison it's logical to have the same command between the two examples. Other examples are more consistent with this

For problem 1 I suggest changing it to a basic echo. It's the first thing you see in the documentation page, it should be basic.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@potiuk potiuk merged commit 02ba205 into apache:main May 28, 2024
57 of 58 checks passed
@utkarsharma2 utkarsharma2 added changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:improvement Changelog: Improvements type:misc/internal Changelog: Misc changes that should appear in change log and removed changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) type:improvement Changelog: Improvements labels Jun 3, 2024
fdemiane pushed a commit to fdemiane/airflow that referenced this pull request Jun 6, 2024
…ty (apache#39871)

* Refactor example_bash_operator command for simplicity

* Refactor example_bash_decorator for consistency with the operator counterpart
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…ty (apache#39871)

* Refactor example_bash_operator command for simplicity

* Refactor example_bash_decorator for consistency with the operator counterpart
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants