Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added OL support for AzureBlobStorageToGCSOperator in google provider package #40290

Merged
merged 8 commits into from
Jun 20, 2024

Conversation

rahul-madaan
Copy link
Contributor

Added OpenLineage support for AzureBlobStorageToGCSOperator

the operator transfers single file from Azure Blob Storage to Google cloud storage.

@boring-cyborg boring-cyborg bot added area:providers provider:google Google (including GCP) related issues labels Jun 18, 2024
Copy link

boring-cyborg bot commented Jun 18, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@rahul-madaan rahul-madaan changed the title [WIP] feat: added get_openlineage_facets_on_start function in operator definition feat: added get_openlineage_facets_on_start function in operator definition Jun 18, 2024
@rahul-madaan rahul-madaan marked this pull request as ready for review June 18, 2024 20:31
@rahul-madaan rahul-madaan changed the title feat: added get_openlineage_facets_on_start function in operator definition feat: added OL support for AzureBlobStorageToGCSOperator in google provider package Jun 18, 2024
@potiuk
Copy link
Member

potiuk commented Jun 20, 2024

Some formatting to fix (I recommend installing pre-commit and letting it fix it for you)

@mobuchowski mobuchowski merged commit 19fc7d2 into apache:main Jun 20, 2024
51 checks passed
Copy link

boring-cyborg bot commented Jun 20, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
…ovider package (apache#40290)

* added get_openlineage_facets_on_start function in operator definition

* updated account name fetch from connection and added test

* added account_name test in azure for blob

* removed gcs hook and execute() from test

* used pre-commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers provider:google Google (including GCP) related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants