-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AIP-62: Add HookLineageCollector #40335
AIP-62: Add HookLineageCollector #40335
Conversation
7382021
to
1293a07
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, however, I'd add some more "practical tests" that show how mechanism works.
Would also love to see better documentation, though I think it can just link to something that would be populated later in provider docs in followup PR.
1293a07
to
4e81003
Compare
ce0994c
to
75ec801
Compare
@uranusjr want to take another look? |
585ec21
to
f6af11a
Compare
b651b1a
to
6c9e124
Compare
0380e68
to
5f6c253
Compare
1f54e98
to
53f6a97
Compare
53f6a97
to
adecb55
Compare
should register and hold lineage sent from hooks. Add HookLineageReader that defines whether HookLineageCollector should be enabled to process lineage sent from hooks. Add Dataset factories to make sure Datasets registered with HookLineageCollector is AIP-60 compliant. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
adecb55
to
89fed8e
Compare
Add section in experimental lineage docs. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
89fed8e
to
351d2bc
Compare
* Add HookLineageCollector that during task execution should register and hold lineage sent from hooks. Add HookLineageReader that defines whether HookLineageCollector should be enabled to process lineage sent from hooks. Add Dataset factories to make sure Datasets registered with HookLineageCollector is AIP-60 compliant. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> * Remove default `create_dataset` method. Add section in experimental lineage docs. Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com> --------- Signed-off-by: Jakub Dardzinski <kuba0221@gmail.com>
Add HookLineageCollector that during task execution should register and hold lineage sent from hooks.
Add HookLineageReader that defines whether HookLineageCollector should be enabled to process lineage sent from hooks.
Add Dataset factories to make sure Datasets registered with HookLineageCollector is AIP-60 compliant.
Closes: #38766
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.