Fix class instance vs. class type in validate_database_executor_compatibility() call #40626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscheffl
force-pushed
the
bugfix/class-instance-to-class-type
branch
from
8fa26da
to
1162ac3
Compare
potiuk
approved these changes
Jul 7, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
…tibility() call (apache#40626) * Fix class instance vs. class type in check call * Fix class instance vs. class type in check call, adjust pytests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing AIP-69 I realized that the call to
validate_database_executor_compatibility()is actually expecting atype[BaseExecutor]but in one call a class instance ofBaseExecutoris handed over.In most cases this did not generate an error (yet) and I am wondering why mypy did not complain (I assume mainly because the wrapper of LRU cache)... anyway, this PR corrects the call.