Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny PR: Fix two typos in Weaviate provider code #40670

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

TJaniF
Copy link
Contributor

@TJaniF TJaniF commented Jul 9, 2024

Fixing grcp -> grpc and get_collection_configuraiton to get_collection_configuration

both of these typos were introduced in #40194 which has not been part of a released version yet, so does not break anything :)

cc: @Lee-W

@potiuk
Copy link
Member

potiuk commented Jul 9, 2024

Actually that one - even if smalll - might want us to decide on cancelling waeviate from the current wave and creating rc2 (@Lee-W @eladkal )

@potiuk
Copy link
Member

potiuk commented Jul 9, 2024

See #40661 @TJaniF -> the provider's rc1 is being voted

@TJaniF
Copy link
Contributor Author

TJaniF commented Jul 9, 2024

See #40661 @TJaniF -> the provider's rc1 is being voted

Oh, I had not seen the vote email this morning, sorry!

@potiuk
Copy link
Member

potiuk commented Jul 9, 2024

Oh, I had not seen the vote email this morning, sorry!

Nothing to be sorry about :) ! There are so many things happening that I am somewhat surprise I am able to follow it :D

Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a major release in case someone provides the extra grcp_secure or uses the public method get_collection_configuraiton.

@hussein-awala
Copy link
Member

Actually that one - even if smalll - might want us to decide on cancelling waeviate from the current wave and creating rc2

If the change is not released yet, +1 to cancel the RC

@TJaniF
Copy link
Contributor Author

TJaniF commented Jul 9, 2024

Actually that one - even if smalll - might want us to decide on cancelling waeviate from the current wave and creating rc2

If the change is not released yet, +1 to cancel the RC

yes, the typos are not in any released version

@eladkal eladkal merged commit 728ee2e into apache:main Jul 9, 2024
51 checks passed
@Lee-W
Copy link
Member

Lee-W commented Jul 9, 2024

Thank @TJaniF for the prompt fixing. Didn't notice it 🤦‍♂️

romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants