Fix and adjust URL generation for UI grid and older runs #40764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eladkal
approved these changes
Jul 13, 2024
hussein-awala
approved these changes
Jul 13, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though there was a PR #39642 and linked several others there is a serious regression to have valid and working links for older DAG runs pointing to grid.
I got a report for such a bug during the week and was stumbling into this with a lot of follow-up issues. I think the grid UI needs to be in general improved towards this but could not find a good entry point.
Nevertheless following other PRs attempting to fix I relalized that passing
base_datehelps until the Grid properly is able to handle older run calls. But theTaskInstance.log_urlproperty does not generate a compatible URL.This PR adjusts the URL generated to be working for older runs.
As I had my hands on it, optimized the map_index off if task is not mapped.