Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing serializations found during provider tests fixing #41252

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Aug 4, 2024

During AWS provider tests fixing for database isolation, two problems have been found:

  • Trigger object did not have TriggerPydantic corresponding pydantic object which did not allow the Trigger object to get serialized for Trigger processing

  • Variable and connection accessors were not restored when Context got deserialized.

Related: #41067


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

During AWS provider tests fixing for database isolation, two
problems have been found:

* Trigger object did not have TriggerPydantic corresponding pydantic
  object which did not allow the Trigger object to get serialized
  for Trigger processing

* Variable and connection accessors were not restored when Context
  got deserialized.

Related: apache#41067
@potiuk potiuk force-pushed the fix-missing-serializations-for-database-isolation-mode branch from dd71724 to e2a852f Compare August 4, 2024 13:09
Copy link
Member

@hussein-awala hussein-awala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good and makes sense.

@potiuk potiuk merged commit 0edcf06 into apache:main Aug 4, 2024
49 checks passed
@potiuk potiuk deleted the fix-missing-serializations-for-database-isolation-mode branch August 4, 2024 14:40
@utkarsharma2 utkarsharma2 added the type:misc/internal Changelog: Misc changes that should appear in change log label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:serialization area:Triggerer type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants