fix DagPriorityParsingRequest unique constraint error when dataset aliases are resolved into new datasets #41398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lee-W
force-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
953a2a7
to
342bc09
Compare
Lee-W
requested review from
potiuk,
ashb,
kaxil,
eladkal,
o-nikolas,
jedcunningham,
hussein-awala,
uranusjr,
jhtimmins,
ryanahamilton,
bbovenzi,
pierrejeambrun,
ephraimbuddy,
dstandish,
bolkedebruin and
XD-DENG
as code owners
|
will create another PR point to main once merged |
|
FYI - this one has a lot more commits than intended I think |
|
ah yes, I should rebase from |
Lee-W
force-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
342bc09
to
de5e735
Compare
|
@Lee-W We should raise this PR against the main and once merged, we'll do a cherry-pick to |
|
Got it. Thanks @utkarsharma2 ! let me change it |
Lee-W
force-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
de5e735
to
ad2f621
Compare
ephraimbuddy
approved these changes
Aug 12, 2024
Lee-W
force-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
0c54643
to
c62728c
Compare
eladkal
approved these changes
Aug 12, 2024
…t error when dataset aliases are resolved into new datasets this happens when dynamic task mapping is used
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com>
Lee-W
force-pushed
the
fix-dag-parsing-request-unique-constraint-error
branch
from
c62728c
to
82d86f0
Compare
utkarsharma2
approved these changes
Aug 12, 2024
utkarsharma2
deleted the
fix-dag-parsing-request-unique-constraint-error
branch
utkarsharma2
added
the
changelog:skip
utkarsharma2
pushed a commit
that referenced
this pull request
Aug 12, 2024
…iases are resolved into new datasets (#41398) * fix(datasets/manager): fix DagPriorityParsingRequest unique constraint error when dataset aliases are resolved into new datasets this happens when dynamic task mapping is used * refactor(dataset/manager): reword debug log Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> * refactor(dataset/manager): remove unnecessary logging Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> --------- Co-authored-by: Ephraim Anierobi <splendidzigy24@gmail.com> (cherry picked from commit bf64cb6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This happens when dynamic task mapping is used as each task create the exact same
DagPriorityParsingRequests.What
Follow how dataset queue a DagRun. ignore the conflict trasctions
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.