-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(providers/openai): support batch api in hook/operator/trigger #41554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josix
force-pushed
the
feat/openai/support-batch-api
branch
from
August 17, 2024 16:39
bfd7cfc
to
2641b4a
Compare
ginger0207
reviewed
Aug 19, 2024
josix
force-pushed
the
feat/openai/support-batch-api
branch
2 times, most recently
from
August 19, 2024 19:06
a0b3069
to
95a8b0b
Compare
Co-authored-by: YungHsiu Chen <yunghsiu1994@gmail.com>
josix
force-pushed
the
feat/openai/support-batch-api
branch
from
August 19, 2024 19:39
95a8b0b
to
6410863
Compare
josix
force-pushed
the
feat/openai/support-batch-api
branch
from
August 19, 2024 19:56
6410863
to
2bba21a
Compare
vincbeck
reviewed
Aug 19, 2024
Lee-W
reviewed
Aug 20, 2024
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
josix
force-pushed
the
feat/openai/support-batch-api
branch
from
August 20, 2024 12:43
92718bd
to
d2a5415
Compare
vincbeck
reviewed
Aug 20, 2024
josix
force-pushed
the
feat/openai/support-batch-api
branch
from
August 20, 2024 16:25
d2a5415
to
2bc3c4b
Compare
josix
commented
Aug 20, 2024
josix
commented
Aug 20, 2024
vincbeck
approved these changes
Aug 20, 2024
Lee-W
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left one nitpick. we should be able to merge this one once addressed
ginger0207
approved these changes
Aug 21, 2024
Lee-W
approved these changes
Aug 21, 2024
potiuk
added a commit
to potiuk/airflow
that referenced
this pull request
Aug 22, 2024
The apache#41554 broke exclusion of openai tests when no pydantic is installed.
potiuk
added a commit
that referenced
this pull request
Aug 22, 2024
The #41554 broke exclusion of openai tests when no pydantic is installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #41336
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.