Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(providers/openai): support batch api in hook/operator/trigger #41554

Merged
merged 14 commits into from
Aug 22, 2024

Conversation

josix
Copy link
Contributor

@josix josix commented Aug 17, 2024

closes: #41336

  • Hook that supports batch api related operation
  • Operator/Trigger for Batch API
  • Unit tests for new added behaviors to hook
  • Unit tests for new added behaviors to operator
  • Unit tests for new added behaviors to trigger
  • Update how-to guide
  • Update provider.yaml

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@josix josix force-pushed the feat/openai/support-batch-api branch 2 times, most recently from a0b3069 to 95a8b0b Compare August 19, 2024 19:06
@josix josix marked this pull request as ready for review August 19, 2024 19:07
@josix josix force-pushed the feat/openai/support-batch-api branch from 95a8b0b to 6410863 Compare August 19, 2024 19:39
@josix josix force-pushed the feat/openai/support-batch-api branch from 6410863 to 2bba21a Compare August 19, 2024 19:56
airflow/providers/openai/hooks/openai.py Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/operators/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/operators/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/triggers/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/triggers/openai.py Outdated Show resolved Hide resolved
airflow/providers/openai/triggers/openai.py Outdated Show resolved Hide resolved
josix and others added 7 commits August 20, 2024 18:33
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
Co-authored-by: Wei Lee <weilee.rx@gmail.com>
@josix josix force-pushed the feat/openai/support-batch-api branch from 92718bd to d2a5415 Compare August 20, 2024 12:43
@josix josix force-pushed the feat/openai/support-batch-api branch from d2a5415 to 2bc3c4b Compare August 20, 2024 16:25
@josix josix requested review from Lee-W and vincbeck August 20, 2024 16:47
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one nitpick. we should be able to merge this one once addressed

airflow/providers/openai/exceptions.py Outdated Show resolved Hide resolved
airflow/providers/openai/hooks/openai.py Outdated Show resolved Hide resolved
@josix josix requested a review from ginger0207 August 21, 2024 09:22
@Lee-W Lee-W merged commit 00e73e6 into apache:main Aug 22, 2024
53 checks passed
potiuk added a commit to potiuk/airflow that referenced this pull request Aug 22, 2024
The apache#41554 broke exclusion of openai tests when no pydantic is
installed.
potiuk added a commit that referenced this pull request Aug 22, 2024
The #41554 broke exclusion of openai tests when no pydantic is
installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OpenAI Provider] Support Batch API in OpenAI Hook
4 participants