-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-XXX] Update docs with new BranchPythonOperator behaviour #4682
Conversation
docs/concepts.rst
Outdated
.. image:: img/branch_bad.png | ||
Paths of the branching task are ``branch_a``, ``join`` and ``branch_b``. Since | ||
``join`` is a downstream task of ``branch_a``, it will be excluded from the skipped | ||
tasks when ``branch_a`` is selected by the Python function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say is returned by the Python callable instead of is selected by the Python function.
to keep using the same wording.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, fixed.
Codecov Report
@@ Coverage Diff @@
## master #4682 +/- ##
==========================================
- Coverage 74.35% 73.17% -1.18%
==========================================
Files 430 432 +2
Lines 27962 28414 +452
==========================================
+ Hits 20790 20791 +1
- Misses 7172 7623 +451
Continue to review full report at Codecov.
|
The previous PR is irrelevant? |
@BasPH FYI, CI test failed, submit PR to try again. |
@zhongjiajie I've restarted the failed job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for giving some love to the documentation @BasPH
Make sure you have checked all steps below.
Jira
Description
After #4666 the docs had to be updated to explain the
BranchPythonOperator
correctly:Tests
Commits
Documentation
Code Quality
flake8