[AIRFLOW-4443] Document behavior of LatestOnlyOperator for externally triggered dagrun #5214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A LatestOnlyOperator task will never skip downstream tasks if run in an externally triggered dagrun. This is probably reasonable–the software is not making assumptions about the trigger-er's intention when creating an unscheduled dagrun, and in that agnostic state, the default behavior would be to not skip any tasks. However, that rationale may not be obvious to an enduser, who may be confused why a latest-only task in an externally triggered dagrun with an execution_date in the past is not skipping downstream tasks. This commit updates the docstring for the LatestOnlyOperator to clarify the operator's behavior in this scenario.
Codecov Report
@@ Coverage Diff @@
## master #5214 +/- ##
=======================================
Coverage 78.53% 78.53%
=======================================
Files 469 469
Lines 29965 29965
=======================================
Hits 23534 23534
Misses 6431 6431
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A LatestOnlyOperator task will never skip downstream tasks if run in an
externally triggered dagrun. This is probably reasonable–the software
is not making assumptions about the trigger-er's intention when creating
an unscheduled dagrun, and in that agnostic state, the default behavior
would be to not skip any tasks.
However, that rationale may not be obvious to an enduser, who may be
confused why a latest-only task in an externally triggered dagrun with
an execution_date in the past is not skipping downstream tasks.
This PR updates the docstring for the LatestOnlyOperator to clarify
the operator's behavior in this scenario.