-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5444] Fix action_logging so that request.form for POST is logged #6064
Conversation
31a8d05
to
04a5011
Compare
Codecov Report
@@ Coverage Diff @@
## master #6064 +/- ##
=========================================
- Coverage 80.04% 79.65% -0.4%
=========================================
Files 607 607
Lines 35033 35033
=========================================
- Hits 28043 27904 -139
- Misses 6990 7129 +139
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. But giving another one a chance to look it over. Maybe @ashb
…gged - Log request.values so both GET and POST are properly logged - Add a test for action_logging
04a5011
to
c8c4a12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, but it's just occurred to me that this might miss some actions entirely - ones that are using the Flask-AppBuilder model views etc.
Thanks, @ashb. I looked at views.py again, most views inherit from Also, what's the path from here? Can one of the committers help merge this PR now it's approved? |
I'll merge this PR as it fixes a bug.
|
…gged (apache#6064) (apache#379) Log request.values so both GET and POST are properly logged
Make sure you have checked all steps below.
Jira
Description
When user performs actions such as "clear", "success" or "failed" on the WebUI, important parameters such as dag_id, task_id and execution_date are not logged by action_logging because the values are in request.form rather than request.args. This PR fixes the issue.
Tests
Added tests.www.test_views:TestDecorators to check for the scenario where request.method is GET and POST.
Commits
Documentation