Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-XXX] Add message about breaking change in DAG#get_task_instances #6226

Merged
merged 2 commits into from
Oct 4, 2019

Conversation

danmactough
Copy link
Contributor

Make sure you have checked all steps below.

Jira

  • My PR addresses the following Airflow Jira issues and references them in the PR title. For example, "[AIRFLOW-XXX] My Airflow PR"
    • https://issues.apache.org/jira/browse/AIRFLOW-XXX
    • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-XXX], code changes always need a Jira issue.
    • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
    • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

Adds a note to UPDATING.md to describe breaking change to get_task_instances method of DAG.

@ashb

Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry we missed this breaking change in the first place.

@kepta
Copy link

kepta commented Oct 1, 2019

I think the BaseOperator's method get_task_instances is affected in this case and any class (like DAG) extending it would be affected:

def get_task_instances(self, start_date=None, end_date=None, session=None):

@danmactough danmactough force-pushed the add-message-about-breaking-change branch from 4ac0d29 to e9dd611 Compare October 1, 2019 16:11
@danmactough
Copy link
Contributor Author

I think the BaseOperator's method get_task_instances is affected in this case and any class (like DAG) extending it would be affected:

Yup. Updated in e9dd61198. Thanks @kepta.

@danmactough danmactough force-pushed the add-message-about-breaking-change branch from e9dd611 to 8d9f8a7 Compare October 2, 2019 02:54
@kaxil kaxil force-pushed the master branch 2 times, most recently from 558f9f1 to d719e1f Compare October 2, 2019 15:30
@ashb ashb force-pushed the add-message-about-breaking-change branch from e75645b to d35b047 Compare October 4, 2019 09:28
@codecov-io
Copy link

Codecov Report

Merging #6226 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6226   +/-   ##
=======================================
  Coverage   80.06%   80.06%           
=======================================
  Files         610      610           
  Lines       35261    35261           
=======================================
  Hits        28232    28232           
  Misses       7029     7029

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3731b1...d35b047. Read the comment docs.

@ashb ashb merged commit debd164 into apache:master Oct 4, 2019
ashb pushed a commit that referenced this pull request Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants