[AIRFLOW-5102] Worker jobs should terminate themselves if they can't heartbeat #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
force-pushed
the
stop-after-failed-heartbeat
branch
from
8bb0e96
to
958604b
Compare
6 tasks
…heartbeat If a LocalTaskJob fails to heartbeat for scheduler_zombie_task_threshold, it should shut itself down. However, at some point, a change was made to catch exceptions inside the heartbeat, so the LocalTaskJob thought it had managed to heartbeat successfully. This effectively means that zombie tasks don't shut themselves down. When the scheduler reschedules the job, this means we could have two instances of the task running concurrently.
ashb
force-pushed
the
stop-after-failed-heartbeat
branch
from
958604b
to
295ee8b
Compare
kaxil
approved these changes
Oct 8, 2019
Codecov Report
@@ Coverage Diff @@
## master #6284 +/- ##
==========================================
- Coverage 80.32% 80.31% -0.01%
==========================================
Files 612 612
Lines 35395 35396 +1
==========================================
- Hits 28432 28430 -2
- Misses 6963 6966 +3
Continue to review full report at Codecov.
|
ashb
commented
Oct 8, 2019
| @@ -111,8 +111,7 @@ def test_localtaskjob_heartbeat(self, mock_pid): | |||
| session.merge(ti) | |||
| session.commit() | |||
|
|
|||
| ret = job1.heartbeat_callback() | |||
| self.assertEqual(ret, None) | |||
| job1.heartbeat_callback() | |||
There was a problem hiding this comment.
This change was cos pylint started complaining about it.
ashb
added a commit
to ashb/airflow
that referenced
this pull request
Oct 10, 2019
…heartbeat (apache#6284) If a LocalTaskJob fails to heartbeat for scheduler_zombie_task_threshold, it should shut itself down. However, at some point, a change was made to catch exceptions inside the heartbeat, so the LocalTaskJob thought it had managed to heartbeat successfully. This effectively means that zombie tasks don't shut themselves down. When the scheduler reschedules the job, this means we could have two instances of the task running concurrently. (cherry picked from commit 68b8ec5)
arcadecoffee
pushed a commit
to SpareFoot/incubator-airflow
that referenced
this pull request
Feb 5, 2020
…heartbeat (apache#6284) If a LocalTaskJob fails to heartbeat for scheduler_zombie_task_threshold, it should shut itself down. However, at some point, a change was made to catch exceptions inside the heartbeat, so the LocalTaskJob thought it had managed to heartbeat successfully. This effectively means that zombie tasks don't shut themselves down. When the scheduler reschedules the job, this means we could have two instances of the task running concurrently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure you have checked all steps below.
Jira
Description
If a LocalTaskJob fails to heartbeat for scheduler_zombie_task_threshold, it should shut itself down.
However, at some point, a change was made to catch exceptions inside the heartbeat, so the LocalTaskJob thought it had managed to heartbeat successfully.
This effectively means that zombie tasks don't shut themselves down. When the scheduler reschedules the job, this means we could have two instances of the task running concurrently.
Tests
self.latest_heartbeatis only updated when the DB is updated.Commits
Documentation