-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-5704] Improve Kind Kubernetes scripts for local testing #6516
Conversation
eaa04ae
to
ce29eca
Compare
d502319
to
8e2940b
Compare
@ashb @dimberman @gerardo -> I merged all the smaller PRs separated out from the Kind change and I am working on making the tests work for this one. While trying to fix and tests the kubernetes tests I noticed how difficult it was to iterate and re-test Kubernetes tests, so this one is now optimising even more:
I am still working on fixing the tests but I think it is much more developer-friendly than before. |
f2b7a52
to
873fa35
Compare
I'm getting an error If that's a required argument it should fail up front. |
873fa35
to
92ccb9d
Compare
92ccb9d
to
427817c
Compare
427817c
to
b7780c6
Compare
f4bc94e
to
1e43c78
Compare
f850d77
to
b289069
Compare
b289069
to
4d8e9d1
Compare
* Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch
4d8e9d1
to
bed4dcb
Compare
@nuclearpinguin @kaxil @mik-laj - one last final review and I'd love to merge it |
* Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch (cherry picked from commit 73403cc)
* Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch (cherry picked from commit 73403cc)
* Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch (cherry picked from commit 73403cc)
* Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch (cherry picked from commit 73403cc)
* Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch (cherry picked from commit 73403cc)
…che#6516) * Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch
…che#6516) * Fixed problem that Kubernetes tests were testing latest master rather than what came from the local sources. * Kind (Kubernetes in Dcocker) is run in the same Docker as Breeze env * Moved Kubernetes scripts to 'in_container' dir where they belong now * Kubernetes cluster is reused until it is stopped * Kubernetes image is build from image in docker already + mounted sources * Kubectl version name is corrected in the Dockerfile * KUBERNETES_VERSION can now be used to select Kubernetes version * Running kubernetes scripts is now easy in Breeze * We can start/recreate/stop cluster using --<ACTION>-kind-cluster * Instructions on how to run Kubernetes tests are updated * The old "bare" environment is replaced by --no-deps switch (cherry picked from commit 73403cc) (cherry picked from commit c7c5aa3)
rather than what came from the local sources.
Issue link: AIRFLOW-5704
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.