Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-5834] Option to skip serve_logs process with workers #6709

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@msumit
Copy link
Contributor

msumit commented Dec 2, 2019

Make sure you have checked all steps below.

Jira

Description

  • Adding an option to skip serve logs process starting with workers. With the advent of K8s, serving logs from workers isn't useful anymore. Also, fundamentally it feels wrong to serve two entirely diff processes from one command.

Tests

  • Added unit tests

Commits

  • My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
    1. Subject is separated from body by a blank line
    2. Subject is limited to 50 characters (not including Jira issue reference)
    3. Subject does not end with a period
    4. Subject uses the imperative mood ("add", not "adding")
    5. Body wraps at 72 characters
    6. Body explains "what" and "why", not "how"

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
    • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 2, 2019

Codecov Report

Merging #6709 into master will decrease coverage by 0.28%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6709      +/-   ##
==========================================
- Coverage   83.83%   83.55%   -0.29%     
==========================================
  Files         668      668              
  Lines       37569    37575       +6     
==========================================
- Hits        31497    31395     -102     
- Misses       6072     6180     +108
Impacted Files Coverage Δ
airflow/bin/cli.py 92.64% <ø> (ø) ⬆️
airflow/cli/commands/worker_command.py 77.08% <88.88%> (+38.98%) ⬆️
airflow/kubernetes/volume_mount.py 44.44% <0%> (-55.56%) ⬇️
airflow/kubernetes/volume.py 52.94% <0%> (-47.06%) ⬇️
airflow/kubernetes/pod_launcher.py 45.25% <0%> (-46.72%) ⬇️
airflow/kubernetes/refresh_config.py 50.98% <0%> (-23.53%) ⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py 78.2% <0%> (-20.52%) ⬇️
airflow/jobs/local_task_job.py 85% <0%> (-5%) ⬇️
airflow/configuration.py 89.13% <0%> (-3.63%) ⬇️
airflow/utils/dag_processing.py 58.15% <0%> (+0.16%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fed459...42e45f9. Read the comment docs.

@msumit msumit requested review from aoen and kaxil Dec 2, 2019
pylintrc Outdated Show resolved Hide resolved
airflow/cli/commands/worker_command.py Outdated Show resolved Hide resolved
airflow/cli/commands/worker_command.py Show resolved Hide resolved
pylintrc Outdated Show resolved Hide resolved
airflow/cli/commands/worker_command.py Outdated Show resolved Hide resolved
@msumit msumit force-pushed the msumit:AIRFLOW_5834 branch from 58ccc8f to 42e45f9 Dec 3, 2019
@aoen aoen merged commit fac3653 into apache:master Dec 3, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
kaxil added a commit that referenced this pull request Dec 18, 2019
ashb added a commit that referenced this pull request Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.