-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6239] Filter dags return by last_dagruns #6804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add dag_ids get parameter to last_dagruns endpoint so can filter by the set of dag_ids present on the dags view. This is intended to speed up the response time on systems running a large number of dags.
dimberman
requested changes
Dec 12, 2019
dimberman
approved these changes
Dec 12, 2019
Codecov Report
@@ Coverage Diff @@
## master #6804 +/- ##
=========================================
Coverage ? 84.59%
=========================================
Files ? 672
Lines ? 38225
Branches ? 0
=========================================
Hits ? 32338
Misses ? 5887
Partials ? 0
Continue to review full report at Codecov.
|
ashb
pushed a commit
to ashb/airflow
that referenced
this pull request
Dec 18, 2019
Add dag_ids get parameter to last_dagruns endpoint so can filter by the set of dag_ids present on the dags view. This is intended to speed up the response time on systems running a large number of dags. (cherry picked from commit bdcd7cd)
ashb
pushed a commit
that referenced
this pull request
Dec 18, 2019
Add dag_ids get parameter to last_dagruns endpoint so can filter by the set of dag_ids present on the dags view. This is intended to speed up the response time on systems running a large number of dags. (cherry picked from commit bdcd7cd)
ashb
pushed a commit
that referenced
this pull request
Dec 19, 2019
Add dag_ids get parameter to last_dagruns endpoint so can filter by the set of dag_ids present on the dags view. This is intended to speed up the response time on systems running a large number of dags. (cherry picked from commit bdcd7cd)
kaxil
pushed a commit
that referenced
this pull request
Dec 19, 2019
Add dag_ids get parameter to last_dagruns endpoint so can filter by the set of dag_ids present on the dags view. This is intended to speed up the response time on systems running a large number of dags. (cherry picked from commit bdcd7cd)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
Add dag_ids get parameter to last_dagruns endpoint so can filter by the set of dag_ids present on the dags view. This is intended to speed up the response time on systems running a large number of dags.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dag_ids get parameter to last_dagruns endpoint so can filter by the
set of dag_ids present on the dags view. This is intended to speed up
the response time on systems running a large number of dags.
Jira
Description
The last_dagruns endpoint returns all dags by default. This can result in an extremely slow response time when you have a lot of dags (In our case 1500+ takes 8 seconds).
The accompanying pull request adds a dag_ids get parameter to the last_dagruns end point which is populated by the dags present on the page.
Please see related and merged issue for task_stats: https://issues.apache.org/jira/browse/AIRFLOW-6095
Tests
(see test_views)
Commits
Documentation
NA