[AIRFLOW-6359] spark_submit_hook.py status polling interval config

[tooptoop4]

Make sure you have checked all steps below.

Jira

• My PR addresses the following AIRFLOW-6359 issues and references them in the PR title. For example, "[AIRFLOW-6359] My Airflow PR"
  • https://issues.apache.org/jira/browse/AIRFLOW-6359
  • In case you are fixing a typo in the documentation you can prepend your commit with [AIRFLOW-6359], code changes always need a Jira issue.
  • In case you are proposing a fundamental code change, you need to create an Airflow Improvement Proposal (AIP).
  • In case you are adding a dependency, check if the license complies with the ASF 3rd Party License Policy.

Description

• Here are some details about my PR, including screenshots of any UI changes:

Tests

• My PR adds the following unit tests OR does not need testing for this extremely good reason:

Commits

• My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
  1. Subject is separated from body by a blank line
  2. Subject is limited to 50 characters (not including Jira issue reference)
  3. Subject does not end with a period
  4. Subject uses the imperative mood ("add", not "adding")
  5. Body wraps at 72 characters
  6. Body explains "what" and "why", not "how"

Documentation

• In case of new functionality, my PR adds documentation that describes how to use it.
  • All the public functions and the classes in the PR contain docstrings that explain what it does
  • If you implement backwards incompatible changes, please leave a note in the Updating.md so we can assign it to a appropriate release

[potiuk]

Same here @tooptoop4 -> pre-commit checks are helpful to catch those static-check problems before they are committed/pushed to the repo.

[tooptoop4]

travis unrelated?

[turbaszek]

I am not sure about this change. In my opinion status_poll_interval should be configured when initialising the hook. It's rather uncommon to have service specific configuration in config.

[potiuk]

Agree with @nuclearpinguin. While we already have hive/atlas in there, I think we should get rid of it in favour of configuring the parameters currently in conf via hook parameters. I would love to hear other opinions on that subject - maybe we should have a new JIRA issue ("get rid of non-core extra conf entries) or something like that?

[tooptoop4]

do u mean in my dags i should pass the argument to sparkoperator? (then need to do pr for the operator to use it)

[codecov-io]

Codecov Report

Merging #6909 into master will decrease coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #6909      +/-   ##
==========================================
- Coverage   84.72%   84.42%   -0.31%     
==========================================
  Files         679      680       +1     
  Lines       38505    38558      +53     
==========================================
- Hits        32623    32551      -72     
- Misses       5882     6007     +125

Impacted Files	Coverage Δ
airflow/contrib/hooks/spark_submit_hook.py	82.07% <100%> (-0.43%)	⬇️
airflow/contrib/operators/spark_submit_operator.py	92.85% <100%> (+0.17%)	⬆️
airflow/contrib/hooks/cassandra_hook.py	0% <0%> (-100%)	⬇️
airflow/kubernetes/volume_mount.py	44.44% <0%> (-55.56%)	⬇️
airflow/kubernetes/volume.py	52.94% <0%> (-47.06%)	⬇️
airflow/kubernetes/pod_launcher.py	45.25% <0%> (-46.72%)	⬇️
airflow/kubernetes/refresh_config.py	50.98% <0%> (-23.53%)	⬇️
...rflow/contrib/operators/kubernetes_pod_operator.py	78.75% <0%> (-20%)	⬇️
airflow/models/__init__.py	91.3% <0%> (-8.7%)	⬇️
airflow/utils/cli.py	71.69% <0%> (-3.04%)	⬇️
... and 18 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fffa5b...9bdc64a. Read the comment docs.

[turbaszek]

do u mean in my dags i should pass the argument to sparkoperator? (then need to do pr for the operator to use it)

Yes, imho that is the way to go

[tooptoop4]

@nuclearpinguin updated to not use .cfg

[tooptoop4]

@nuclearpinguin updates made

[tooptoop4]

@nuclearpinguin can u pls merge?