Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6438] Filter dags returned by blocked #7019

Merged

Conversation

robinedwards
Copy link
Contributor

Link to JIRA issue: https://issues.apache.org/jira/browse/AIRFLOW-6438

The /blocked end point returns any blocked dags in the entire system by default. This can be quite slow when running a large amount of dags (2500+ in our case).

This pull request adds a dag_ids get parameter to the blocked end point which is populated by the dags present on the curent page.

Please see previous issues which fixed the other end points in a similar manner AIRFLOW-6239, AIRFLOW-6238, AIRFLOW-6095

  • Description above provides context of the change
  • Commit message starts with [AIRFLOW-NNNN], where AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • [] Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

(*) For document-only changes, no JIRA issue is needed. Commit message starts [AIRFLOW-XXXX].

@robinedwards robinedwards force-pushed the feature/airflow-blocked-by-dag-id branch from 0207d7d to d20234e Compare January 3, 2020 13:24
@github-actions github-actions bot added the area:webserver Webserver related Issues label Jan 5, 2020
Add dag_ids GET parameter to /blocked end point to allow querying of just
the dags present on the current page.
@robinedwards robinedwards force-pushed the feature/airflow-blocked-by-dag-id branch from d20234e to 78550d7 Compare January 6, 2020 08:40
@codecov-io
Copy link

codecov-io commented Jan 6, 2020

Codecov Report

Merging #7019 into master will decrease coverage by <.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #7019      +/-   ##
=========================================
- Coverage   85.01%     85%   -0.01%     
=========================================
  Files         680     680              
  Lines       38748   38752       +4     
=========================================
+ Hits        32940   32942       +2     
- Misses       5808    5810       +2
Impacted Files Coverage Δ
airflow/www/views.py 76.07% <94.44%> (-0.01%) ⬇️
airflow/utils/dag_processing.py 87.8% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbc829f...78550d7. Read the comment docs.

@kaxil kaxil merged commit 5491f4d into apache:master Jan 9, 2020
@kaxil
Copy link
Member

kaxil commented Jan 9, 2020

Good work @robinedwards

kaxil added a commit that referenced this pull request Feb 3, 2020
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
Add dag_ids GET parameter to /blocked end point to allow querying of just
the dags present on the current page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants