[AIRFLOW-6662] install dumb init #7300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
changed the title
mik-laj
reviewed
Jan 31, 2020
airflow/example_dags/libs/helper.py
Outdated
|
|
||
|
|
||
| # pylint: disable=missing-docstring | ||
| def print_stuff(): |
There was a problem hiding this comment.
Used in kubernetes tests.
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
9ba64ef
to
5ea7f2f
Compare
boring-cyborg
bot
added
the
area:Scheduler
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
5ea7f2f
to
2aed3a0
Compare
mik-laj
approved these changes
Jan 31, 2020
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
2aed3a0
to
58e160a
Compare
ashb
approved these changes
Jan 31, 2020
|
Though perhaps instead of a new commit we could/should just revert the previous change? |
Let's see. I think I might not even want to revert it finally because the stability problems seems to be not related to the --init flag usage, I want to fix it first and see how we approach dumb-init eventually. |
|
@potiuk I don't think the revert vs this would make a difference, but this still seems to be failing it's tests? |
|
The failures are different reason - not init i am looking into it. |
|
we have still failing master even if I fixed the "contrib/example" problem (see slack). One is print_diff import and the other is very mysterious hang that cannot be reproduced locally. Both unrelated with the init - so init was not an issue in the first place. |
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
58e160a
to
e05b47e
Compare
Also curl options are now using long format and include --fail to protect against some temporary errors (5xx). Also RAT download uses now two possible sources of downloads and fallbacks to the second if first is not available.
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
e05b47e
to
f743d6c
Compare
…ation (apache#7278)" This reverts commit d1bf343.
We had stability problems with tests with --init flag so we are going back to it
potiuk
force-pushed
the
AIRFLOW-6662-install-dumb-init
branch
from
f743d6c
to
2440252
Compare
Codecov Report
@@ Coverage Diff @@
## master #7300 +/- ##
==========================================
+ Coverage 85.87% 86.12% +0.24%
==========================================
Files 863 863
Lines 40520 40908 +388
==========================================
+ Hits 34798 35232 +434
+ Misses 5722 5676 -46
Continue to review full report at Codecov.
|
potiuk
added a commit
that referenced
this pull request
Feb 2, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it (cherry picked from commit 945b988)
kaxil
pushed a commit
that referenced
this pull request
Feb 3, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it (cherry picked from commit 945b988)
galuszkak
pushed a commit
to FlyrInc/apache-airflow
that referenced
this pull request
Mar 5, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (apache#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Mar 30, 2020
* Revert "[AIRFLOW-6662] Switch to --init docker flag for signal propagation (apache#7278)" This reverts commit d1bf343. * [AIRFLOW-6662] return back the dumb-init - installed by apt We had stability problems with tests with --init flag so we are going back to it (cherry picked from commit 945b988) (cherry picked from commit 3ca84ec)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link: AIRFLOW-6662
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.