Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIRFLOW-6892] Fix broken non-wheel releases #7514

Merged
merged 1 commit into from
Feb 23, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 23, 2020

Our non-wheel releases on pypi are broken

pip install --no-binary apache-airflow apache-airflow

will install a version that does this:

FileNotFoundError: [Errno 2] No such file or directory: '/home/ash/.virtualenvs/clean/lib/python3.7/site-packages/airflow/serialization/schema.json'

There are no issues with wheel package. Pip install wheel package if available and unless you use "--no-binary"specifically


Issue link: AIRFLOW-6892

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Commit message/PR title starts with [AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID*
  • Unit tests coverage for changes (not needed for documentation changes)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

* For document-only changes commit message can start with [AIRFLOW-XXXX].


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from ashb and turbaszek February 23, 2020 14:41
@kaxil kaxil merged commit 20c507f into apache:master Feb 23, 2020
@kaxil kaxil deleted the Fix-broken-non-wheel-releases branch February 23, 2020 15:03
@potiuk
Copy link
Member

potiuk commented Feb 23, 2020

Good that you caught it @kaxil!

@kaxil
Copy link
Member Author

kaxil commented Feb 23, 2020

Credits to @ashb for actually finding this bug :)

Just surprising though that sdist and bdist_wheel use different things to decide what to include in the package

@potiuk
Copy link
Member

potiuk commented Feb 23, 2020

Yeah. Well, they are different things in fact. But indeed I am also unimpressed by the level of consistency and documentation correctness of the setuptools. It's half-baked at most. Seems that part of python never got the love it deserved.

potiuk pushed a commit that referenced this pull request Feb 25, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Feb 27, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Feb 28, 2020
(cherry picked from commit 20c507f)
(cherry picked from commit 69f7d2e)
galuszkak pushed a commit to FlyrInc/apache-airflow that referenced this pull request Mar 5, 2020
kaxil added a commit that referenced this pull request Mar 19, 2020
kaxil added a commit to astronomer/airflow that referenced this pull request Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants