-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6957] Make retrieving Paused Dag ids a separate method #7587
Conversation
Can you also add a test that checks if the DagFileProcessor ignores these DAGs? This is the core, and it's worth one more test than not having it. |
We already have other cases covered: airflow/tests/jobs/test_scheduler_job.py Lines 847 to 854 in 847cb40
and airflow/tests/jobs/test_scheduler_job.py Lines 1162 to 1188 in 847cb40
The bug in the last PR was we were not checking how the results were returned from the query which this PR adds. |
36ee01e
to
f094e29
Compare
Codecov Report
@@ Coverage Diff @@
## master #7587 +/- ##
=========================================
Coverage ? 86.58%
=========================================
Files ? 896
Lines ? 42624
Branches ? 0
=========================================
Hits ? 36905
Misses ? 5719
Partials ? 0
Continue to review full report at Codecov.
|
Separating it out to a method makes it easy to test "just that" functionality.
Issue link: AIRFLOW-6957
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]
. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX]
.In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.